Require building with GHC 8.10 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for some changes that require 8.10 as the minimum GHC version. See #385. Some knock-on changes include: * Unsurprisingly, GHC 8.10 slightly changes the way `-ddump-splices` output is pretty-printed, so some test cases' expected output have been updated accordingly. * Now that we only build against GHC 8.10, we can get rid of some CPP only needed for older GHCs. * GHC 8.10 now warns about unqualified `Data.List` imports, so some minor tweaks are needed to avoid these warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for some changes that require 8.10 as the
minimum GHC version. See #385.
Some knock-on changes include:
Unsurprisingly, GHC 8.10 slightly changes the way
-ddump-splicesoutput is pretty-printed, so some test cases' expected output have been updated accordingly.Now that we only build against GHC 8.10, we can get rid of some CPP only needed for older GHCs.
-Wcompatnow warns about unqualifiedData.Listimports, so some minor tweaks are needed to avoid these warnings.